Skip to content

fix beam snapshot workflow#3326

Merged
derrickaw merged 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260212_fixBeamSnapshots
Feb 17, 2026
Merged

fix beam snapshot workflow#3326
derrickaw merged 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260212_fixBeamSnapshots

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Feb 12, 2026

fix #3322

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@derrickaw derrickaw marked this pull request as ready for review February 12, 2026 21:01
@derrickaw derrickaw requested a review from Abacn February 12, 2026 21:01
@Abacn
Copy link
Contributor

Abacn commented Feb 12, 2026

Is it possible to find which Beam commit causing this flag need to be added? It sounds like a regression in Beam for Java 17+

@derrickaw
Copy link
Contributor Author

Is it possible to find which Beam commit causing this flag need to be added? It sounds like a regression in Beam for Java 17+

Will try to find. Thanks.

@derrickaw
Copy link
Contributor Author

derrickaw commented Feb 12, 2026

Is it possible to find which Beam commit causing this flag need to be added? It sounds like a regression in Beam for Java 17+

Hi @Abacn, pretty sure its because of this PR - apache/beam#37473 with the newer BOM and other dependencies being pulled in. The timing fits because it was merged on Feb 2 around 2:00, while the first failing snapshot in this series was around 7:00 that same day.

@derrickaw
Copy link
Contributor Author

Hi @Abacn, please let me know of any other concerns or if this is ready. Thanks.

@Abacn
Copy link
Contributor

Abacn commented Feb 17, 2026

2026-02-11T18:44:52.4808806Z [ERROR] Errors: 
2026-02-11T18:44:52.4810416Z [ERROR]   SpannerExceptionParserTest.<clinit>:32 » ExceptionInInitializer
2026-02-11T18:44:52.4811848Z [ERROR]   DataflowFailureInjectorTest.testAbruptlyKillWorkers_operationHasError_logsError:106 NoClassDefFound Could not initialize class com.google.cloud.compute.v1.Instance
2026-02-11T18:44:52.4813532Z [ERROR]   DataflowFailureInjectorTest.testAbruptlyKillWorkers_stopsCorrectVms:64 ExceptionInInitializer
2026-02-11T18:44:52.4815100Z [ERROR] com.google.cloud.teleport.v2.spanner.testutils.failureinjectiontesting.NetworkFailureInjectorTest.blockNetwork_egressCreationFails
2026-02-11T18:44:52.4816769Z [ERROR]   Run 1: NetworkFailureInjectorTest.setUp:68 NoClassDefFound Could not initialize class com.google.cloud.compute.v1.Operation
2026-02-11T18:44:52.4819966Z [ERROR]   Run 2: NetworkFailureInjectorTest.blockNetwork_egressCreationFails » UnfinishedStubbing 

We can check in this PR to make test green. Good to reach out to Spanner team notifying the new client may break Java17+ users.

@derrickaw derrickaw merged commit b48e6cb into GoogleCloudPlatform:main Feb 17, 2026
5 of 6 checks passed
@derrickaw derrickaw deleted the 20260212_fixBeamSnapshots branch February 17, 2026 17:53
@tvalentyn
Copy link
Contributor

Do we need to call anything out in Beam's CHANGES.md?

@tvalentyn
Copy link
Contributor

Or, maybe we would have to make an announcement in Breaking changes for template release notes, once we pick up the next beam release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dataflow templates test suite running against Beam snapshots is failing

3 participants