Skip to content

Allow configuration of where the RPC content script is read from via rpcContentScriptDir#135

Open
nessup wants to merge 2 commits intoGoogleChromeLabs:masterfrom
trigramco:master
Open

Allow configuration of where the RPC content script is read from via rpcContentScriptDir#135
nessup wants to merge 2 commits intoGoogleChromeLabs:masterfrom
trigramco:master

Conversation

@nessup
Copy link

@nessup nessup commented Jan 31, 2019

This allows the RPC content script to be arbitrary read from any directory, rather than the default __dirname + '../rpc/rpc.js. This is important in situations where node_modules may be inaccessible in certain situations, such as in production builds.

Co-Authored-By: nessup <nessup@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nessup would it be possible to use require.resolve() instead of introducing configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants