Skip to content

chore: add mypy type checking for src/rag/#46

Merged
jayprakash1 merged 3 commits intomainfrom
chore/add-mypy-type-checking
Mar 16, 2026
Merged

chore: add mypy type checking for src/rag/#46
jayprakash1 merged 3 commits intomainfrom
chore/add-mypy-type-checking

Conversation

@prakja
Copy link
Copy Markdown
Contributor

@prakja prakja commented Mar 16, 2026

Summary

  • Add mypy with config scoped to src/rag/ only (llm_manager, neet_rag, vector_store)
  • Fix all 41 type errors across the 3 files (type annotations only, no behavioral changes)
  • Key fixes: proper Optional types, return annotations, Union types for vector manager, targeted type: ignore for LangChain API stub mismatches
  • src/processors/ and src/utils/ excluded via ignore_errors = true
  • Run: mypy --config-file mypy.ini → 0 errors

@jayprakash1 jayprakash1 merged commit e25bc3e into main Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants