Fix (sc)tptp output when the problem file is in cnf#61
Fix (sc)tptp output when the problem file is in cnf#61jcailler wants to merge 2 commits intoGoelandProver:masterfrom
Conversation
jcailler
added
part:plugins
|
Can you update the test suite with the bug please? |
jcailler
force-pushed
the
fix-otptp-cnf
branch
from
424dca9 to
2a5ada3
Compare
|
Where is the bug exactly? The file you provided outputs "VALID" in the master version so I'm pretty sure an additional check is missing here EDIT: I guess that you want to add the |
jcailler
force-pushed
the
fix-otptp-cnf
branch
from
2a5ada3 to
fc54541
Compare
|
By the way, this is a bug file so it should go in the bug folder under the name |
I though the |
|
No, it is for solved ones so that it doesn't happen again and we have a pointer from the original bug / where they were fixed. |
jcailler
force-pushed
the
fix-otptp-cnf
branch
from
fc54541 to
4c0b575
Compare
|
This fails locally but not in the actions. See #62. |
add test file update test file update test file
jcailler
force-pushed
the
fix-otptp-cnf
branch
from
80bed59 to
a8e4126
Compare
| parser = Parser(f) | ||
|
|
||
| if any(out in parser.arguments for out in outputTest) : | ||
| if any(out in parser.arguments for out in outputTest) and (os.path.exists(os.path.splitext(f)[0] + ".out")) : |
There was a problem hiding this comment.
It'd be great to simply check if a .out exists in this case and remove the option check!
There was a problem hiding this comment.
(I'm requesting the CI as I don't think any change in a .go file is needed)
github-actions
bot
removed
needs:ci
2 participants
Bug fix
Description
Fix the (sc)tptp output when the given problem file is in cnf
Test-suite update
bugs/bug_61.p(in master, this problem panics with -proof when it shouldn't).