Remove PrintError API and always call to Fatal or Anomaly instead#57
Open
jrosain wants to merge 1 commit intoGoelandProver:masterfrom
Open
Remove PrintError API and always call to Fatal or Anomaly instead#57jrosain wants to merge 1 commit intoGoelandProver:masterfrom
PrintError API and always call to Fatal or Anomaly instead#57jrosain wants to merge 1 commit intoGoelandProver:masterfrom
Conversation
jrosain
added
kind:cleanup
jrosain
force-pushed
the
print-error-always-fatal
branch
from
07caee8 to
860281a
Compare
jrosain
force-pushed
the
print-error-always-fatal
branch
from
860281a to
e1355b8
Compare
github-actions
bot
removed
request:ci
jcailler
added
the
needs:rebase
jrosain
force-pushed
the
print-error-always-fatal
branch
from
e1355b8 to
30c890e
Compare
github-actions
bot
removed
needs:ci
jrosain
removed
the
needs:rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goéland had loads of errors that were printed but never managed. As this is bad practice, I've updated all occurrences of
PrintErrorto fail (either as aFatalerror or anAnomaly). I'm not certain that I've got the semantics of 100% of the errors right, but at least we fail when faced with a problematic behaviour. It'll also help for finding issues. It seems that the test suite does not break with this change, so they shouldn't happen too often.PR dependencies