Improve gesture handling, mouse mapping and ZRLE widget support #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add defensive checks for Infinity/NaN values in coordinate calculations - Add _hasValidSize check to prevent errors when widget or image size is invalid - Extract coordinate conversion to helper methods with proper validation
- Fix coordinate calculation to account for BoxFit.contain scaling and centering offsets - Handle different aspect ratios correctly by calculating actual scale and offsets - Fix widget size tracking to update correctly when window is resized - Use ValueListenableBuilder to react to size changes in real-time - Improve SizeTrackingWidget to use LayoutBuilder for accurate size updates
- Update .gitignore to include new build-related directories - Change AppDelegate annotation from @NSApplicationMain to @main - Increment object version and last upgrade check in project.pbxproj - Update MACOSX_DEPLOYMENT_TARGET to 10.15 in project settings - Add GPU validation mode in Runner.xcscheme
Goddchen
requested changes
Jan 7, 2026
- Extract _toRemoteX and _toRemoteY methods to CoordinateConversion extension on double - Improve code readability by using extension methods instead of private methods - Make coordinate conversion logic reusable across the codebase
Co-authored-by: Goddchen <goddchen@googlemail.com>
Co-authored-by: Goddchen <goddchen@googlemail.com>
Co-authored-by: Goddchen <goddchen@googlemail.com>
Co-authored-by: Goddchen <goddchen@googlemail.com>
json_annotation is already provided as a transitive dependency by freezed_annotation, so it doesn't need to be declared explicitly.
Co-authored-by: Goddchen <goddchen@googlemail.com>
Author
|
Hi @Goddchen , I think all points have been resolved on this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the Flutter RFB client:
RemoteFrameBufferWidgetso it can properly handle the ZRLE encoding, making the viewer compatible with more VNC servers and improving rendering robustness.Infinity/NaNerrors in the gesture detector, which previously could cause crashes or erratic behavior under certain input conditions.AppDelegatesetup to better integrate with the updated Flutter/RFB behavior.Overall, these changes make the VNC client more stable and accurate in handling user input and improve compatibility with servers using ZRLE encoding.