서비스 운영 전 점검을 합니다. #362
Open
서비스 운영 전 점검을 합니다. #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis 호스트 설정 변경
비효율적인 엔티티 간 연관관계 개선
관리자 전용 API 접근 권한 부여
CoolSms 환경 변수 추가
모임 이미지 예외처리
모임 기능 관련 상세한 예외처리 로직 추가
프로필 이미지 크기 초과 관련 예외처리 추가
닉네임 수정 시 중복 예외 처리
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to verify SMS notification delivery for meeting creation and matching while preparing for production operational tests. Key changes include:
- Adapting refresh token persistence from a database to Redis
- Enhancing JWT token generation and authentication flows via updated domain classes and services
- Introducing admin functionality (initialization, login, and management) along with updated deployment scripts and CI/CD workflows
Reviewed Changes
Copilot reviewed 169 out of 169 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RefreshTokenRepository.java | Updated to use Redis (CrudRepository) and the new RefreshToken domain |
| LoginRequest.java, TokenType.java, RefreshToken.java | New and updated DTO/Domain classes for authentication token handling |
| CustomMemberDetails.java, CustomMemberDetailsService.java | Revised user detail loading logic with profile image lookup |
| TokenService.java, AdminService.java | Updated token generation and admin authentication logic |
| AdminInitializer.java, AdminController.java, AdminApi.java | Newly added admin endpoints and API definitions |
| Test.java, FestamateApplication.java | Added Sentry testing endpoint and scheduling enablement |
| docker-compose-prod.yml, docker-compose-dev.yml | Updated environment variables and service dependency configurations |
| .github/workflows/cd-prod.yml, cd-dev.yml | Revised CI/CD workflows to include .env generation and deployment steps |
| README.md | Updated project assets and documentation |
Comments suppressed due to low confidence (1)
docker-compose-prod.yml:21
- [nitpick] Ensure that the new service name 'redis-service' is consistently updated in all dependent configurations and scripts to avoid connection issues.
- redis-service
Comment on lines
+68
to
+69
| docker compose -f docker-compose-dev.yml build | ||
| docker compose -f docker-compose-dev.yml push |
There was a problem hiding this comment.
The production CD workflow now uses docker-compose-dev.yml instead of the production compose file, which may lead to deployment mismatches. Please verify if this change is intentional.
Suggested change
| docker compose -f docker-compose-dev.yml build | |
| docker compose -f docker-compose-dev.yml push | |
| docker compose -f docker-compose-prod.yml build | |
| docker compose -f docker-compose-prod.yml push |
| public Map<String, String> loginAdmin(LoginRequest loginRequest) { | ||
|
|
||
| Member member = memberRepository.findByLoginId(loginRequest.getLoginId()) | ||
| .orElseThrow(() -> new RuntimeException("사용자를 찾을 수 없습니다.")); |
There was a problem hiding this comment.
[nitpick] Consider using a more specific exception type instead of RuntimeException for authentication failures to improve error handling and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#357
📝 작업 내용
📷 스크린샷 (선택)
💬 리뷰 요구사항 (선택)