Merged
Conversation
…te parsing - add cleanup_old_processes() to proactively kill lingering chromedriver via pkill - call cleanup_old_processes() at start of perform_checks() to prevent orphaned drivers - enhance run_wifi_diagnostics_task(): detect Tx rate across multiple wdutil keys (Tx Rate, TxRate, Last Tx Rate, Max PHY Rate) - keep robust managed_webdriver_session post-run cleanup as secondary safeguard Tests - test_cleanup.py: cover pkill invocation and exception handling - test_main_flow.py: mock cleanup_old_processes; assert it runs first in perform_checks - test_core.py: parametrize Wi‑Fi Tx rate key variants; maintain existing success/failure cases - minor import/lint cleanups in tests Notes - aligns with acceptance criteria: pre-emptive cleanup logs, no orphaned chromedriver, primary flows intact Refs Ticket: Implement Pre-emptive and Post-run Process Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.