Closed
Conversation
Member
Author
|
@jesdynf okay sir. This is all reviewed, smoke tested, tweaked slightly (requirements.txt and a few doc changes), and squashed. Please take a look and then once you're happy, I'm sure @danielehrlich will be kind enough to do some QA :) |
Member
Author
|
@danielehrlich okay sir, it's up to you :). Please do some testing on this and then merge it |
|
I'll look at all this tomorrow, good stuff (before GoT of course).
Rain is pretty bad, but our apartment is second floor!!
…Sent from my iPhone
On Aug 26, 2017, at 10:57 PM, Matthew Vita ***@***.***> wrote:
@danielehrlich okay sir, it's up to you :). Please do some testing on this and then merge it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
Superceded by #66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.