Open
Conversation
…tes responsibilities
…for BpmAfterFirstNote
Adds hash, notes_hash, timings_hash, and short_hash functions using rkyv serialization and xxh3-128 for deterministic chart fingerprinting.
Add bpm_min, bpm_max, and bpm_mode functions that filter TimingPoint::Bpm variants, with full test coverage including SV-point-ignored and empty-chart cases.
Add nps, density, highest_nps, lowest_nps, and highest_drain_time functions with full test coverage (7 tests, all passing) and zero clippy warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.