Add overworld world generator

[jimmikaelkael]

This merges PR #572 and #597 and add one commit on top of it:
GlowstoneMC/Glowstone@888f784

You can see the results here:
http://imgur.com/a/huhmT

---

Related Links:

• Ticket: World generation #76

[SpaceManiac]

I really love what you've done! The terrain generation looks just fantastic. I've reviewed the implementation a little bit and so far have a few questions:

• The entire ocean floor seems to be gravel (with stone only one layer below). I think this should be dirt instead, and for the first several layers instead of just one, to match vanilla more closely. Thoughts?
• DungeonPopulator's method for picking random tools is commented as if it expects index to be in the [0,3] range, but is called with a 4 index, leading to items with odd rarities:
  • Diamond rarity: STICK
  • Gold rarity: STRING
  • Iron rarity: FLINT_AND_STEEL
  • Stone rarity: DIAMOND_SWORD
  • Wood rarity: STONE_SWORD

[jimmikaelkael]

@SpaceManiac OK I'll try to add several layers of dirt below ocean gravel.
For dungeons, I think what you're talking about is in the actual implementation (which is not interfered with in this PR) which should be replaced once PR #564 pulled and so have the correct chest loots after that.

It still WIP anyway as I need #572 and #597 to be pulled first: it will let me some time to fix a few problems:

• Mesa doesn't have colored stripes (almost done)
• Bryce doesn't have spikes (almost done)
• Mesa forests doesn't have grass and coarse dirt (almost done)
• Switch to Simplex noise for flowers
• Needs several layers of dirt below ocean gravel as you mentionned
• In roofed forest there's not enough tall grass on ground (due to tree density)
• In jungles there's not enough ground bushes
• Caves and Ravine generator isn't done (not planned for this PR)
• Block lighting isn't working and once operational it should overall look better (Not in the scope of this PR)
• Biome temperature is not handled so water placed by the generator is never turned into ice (Not in the scope of this PR)

Another thing that could be cool to refine world gen would be to have AMIDST compatible with Glowstone so that we can check the world map in real time.

[jimmikaelkael]

@SpaceManiac I checked it once again on a fresh vanilla 1.8 generated map in solo and it's stone directly under gravel in oceans.
Possibly you can expect to find some dirt patches here and there because it's populated in stone as an ore.

[SpaceManiac]

Ah, it would seem you are correct on both counts. I was operating on outdated knowledge wrt the ocean floor - you can keep it as-is - and indeed your PR does not touch the DungeonPopulator (I had been reviewing the entire generator package).

[jimmikaelkael]

I think I have handled most of the problems mentionned above, leaving 2 of them for another PR:

• Caves and Ravine generator isn't done
• Block lighting isn't working and once operational it should overall look better

[gdude2002]

This looks pretty fantastic, IMO. Is it done? Can't wait to have this in master ._.

[jimmikaelkael]

I still need to adjust a few things. I'll notify when it's ready which should happen in the coming days ;)

[gdude2002]

<3

[jimmikaelkael]

I think it's ready.

[Tonodus]

I've just reset my world to test your PR.... you've definitely done awesome work! 👍

[bennasar99]

Merge would be awesome.

[gdude2002]

Is there anything holding this back? @SpaceManiac?

[jimmikaelkael]

The two other PRs I guess, #572 and #597.

[turt2live]

@gdude2002 Pending review.