This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Drop the correct drops #540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
@Tonodus You broke the tests with your last commit. |
Contributor
Author
|
@turt2live dammit... fixed. |
turt2live
added
PR: Major Formatting Concerns
and removed
PR: Has Changes
PR: Major Formatting Concerns
labels
Contributor
|
@Tonodus This pull request is no longer mergeable. Please resolve the issue as soon as possible, thanks! |
Contributor
|
The hold for this one isn't really needed, is it? Because I suspect it might be a while until the spreadsheet covers absolutely everything |
Contributor
|
I actually completely forgot about that spreadsheet. I'll work on a better way to generate a list of values though because manual methods are... hard. |
deathcap
referenced
this pull request
in GlowstoneMC/Glowstone
Apr 6, 2015
#540 Conflicts: src/main/java/net/glowstone/block/ItemTable.java src/main/java/net/glowstone/block/blocktype/BlockSapling.java
34 tasks
puigru
pushed a commit
to puigru/Glowstone-Legacy
that referenced
this pull request
Aug 30, 2017
* Revert back to the old Java 8 classpath behavior because of Java 9 delays * Add new libraries for increased compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #527 expect that blocks with hardness 0 won't be dropped (redstone, redstone torches, torches, flowers, etc).
I'm not 100% sure I've added all known cases, I will go through any cases when #527 or this is updated.