Open
Conversation
kievu
reviewed
Jul 23, 2019
| constructor(props: Props) { | ||
| super(props); | ||
| this.state = { | ||
| open: this.props.shouldOpen, |
Contributor
There was a problem hiding this comment.
Det er ikke nødvendig å duplisere en state når den er allerede tilgjengelig som en prop =)
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
kievu
reviewed
Jul 23, 2019
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
vikre
suggested changes
Jul 29, 2019
Contributor
vikre
left a comment
vikre
left a comment
There was a problem hiding this comment.
En liten kommentar som burde/må gjøres alle steder hvor du bruker tekststrenger som kunne vært på forskjellige språk :)
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
vikre
suggested changes
Aug 5, 2019
packages/gdl-frontend/components/WelcomeTutorial/DialogContent.js
Outdated
Show resolved
Hide resolved
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/GlobalDigitalLibraryio/issues/issues/624