Support for nuget package with multiple Roslyn version analyzers in CLI #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoC0de
requested changes
Mar 15, 2025
Collaborator
JoC0de
left a comment
JoC0de
left a comment
There was a problem hiding this comment.
@AlanLiu90 Thanks for providing a fix. The code looks very nice, just some small adjustments and we can merge it.
Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
Co-authored-by: JoC0de <53140583+JoC0de@users.noreply.github.com>
JoC0de
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the logic implemented in #616 to handle nuget package with multiple Roslyn version analyzers in CLI.
Try to fix #704.