Fix handling of duplicate competition IDs in SoaringSpot#63
Merged
sylvainvdm merged 1 commit intodevelopmentfrom Oct 26, 2025
Merged
Fix handling of duplicate competition IDs in SoaringSpot#63sylvainvdm merged 1 commit intodevelopmentfrom
sylvainvdm merged 1 commit intodevelopmentfrom
Conversation
Some SoaringSpot competitions have multiple pilots with identical competition IDs. Previously, this caused IGC files to be overwritten during download, resulting in data loss for all but the last pilot with that ID. This commit resolves the issue by: - Tracking competition IDs as they are processed - Appending suffixes (_2, _3, etc.) to duplicates - Logging warnings when duplicates are detected - Ensuring each pilot gets a unique filename for their IGC file Added comprehensive unit test that verifies: - All competitors are retained (no data loss) - Duplicate IDs are resolved with unique suffixes - Pilot information and rankings are preserved - Both pilots with duplicate IDs can be processed Tested with: https://www.soaringspot.com/nl/keiheuvelcup2025/results/open-xpdr/task-1-on-2025-08-23/daily where two pilots share competition ID "FS"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SoaringSpot competitions have multiple pilots with identical competition IDs. Previously, this caused IGC files to be overwritten during download, resulting in data loss for all but the last pilot with that ID.
This commit resolves the issue by:
Added comprehensive unit test that verifies:
Tested with: https://www.soaringspot.com/nl/keiheuvelcup2025/results/open-xpdr/task-1-on-2025-08-23/daily where two pilots share competition ID "FS"