Feat/openclaude landing page#384
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new landing/ React + Vite + Tailwind application that serves as an OpenClaude marketing/landing page, along with the minimal tooling/config needed to build it.
Changes:
- Added a standalone Vite+React app under
landing/with a styled homepage (App.tsx) and global styles. - Added Tailwind/PostCSS/TypeScript/Vite configuration plus npm manifests for the landing site.
- Added a minimal
package-lock.jsonfor the VS Code extension package.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vscode-extension/openclaude-vscode/package-lock.json | Adds a minimal npm lockfile for the extension package. |
| landing/vite.config.ts | Vite config bootstrapping React plugin. |
| landing/tsconfig.json | TypeScript compiler configuration for the landing app. |
| landing/tailwind.config.ts | Tailwind content scanning + theme stub. |
| landing/src/main.tsx | React root mount + CSS import. |
| landing/src/index.css | Tailwind entry + custom theme/component styles. |
| landing/src/App.tsx | Landing page UI/content and layout. |
| landing/postcss.config.cjs | PostCSS plugins for Tailwind + autoprefixer. |
| landing/package.json | Landing app scripts and dependencies. |
| landing/package-lock.json | Lockfile for landing app dependencies. |
| landing/index.html | HTML entrypoint for Vite/React app. |
| landing/.gitignore | Ignores node_modules and build output for landing app. |
Files not reviewed (1)
- vscode-extension/openclaude-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This is the new PR. Sorry for the problems with the last one. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- vscode-extension/openclaude-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
can we have some screenshots? |
|
@copilot apply changes based on the comments in this thread |
Can do! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- vscode-extension/openclaude-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Follow-up for clarity on my earlier comment: Thanks for the update here. This looks close, but I am not ready to approve it yet. The main gap is verification: the current green check does not appear to exercise the new For a UI-focused PR like this, it would also help to have either screenshots of the final result or some other clear local proof that the landing page is rendering as intended. Please add verification for |
|
@gnanam1990, thanks for the feedback. The PR introduces a brand-new landing page, but the current CI checks only validate the core CLI/test flow, not the new UI app itself. As a result, the PR can be green even if the landing page fails to build or render correctly. Below is a recording of my testing process and the final website. openclaude.Codespaces_.turbo.goggles.-.Visual.Studio.Code.2026-04-06.18-01-50.mp4 |
OpenClaude._.Project-Aware.AI.Companion.and.1.more.page.-.Personal.-.Microsoft.Edge.2026-04-03.16-23-33.mp4 |
|
looks nice. great work on this. please have a look too @Vasanthdev2004 |
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Review: PR #384 — OpenClaude landing page
Reviewed on head c6a7b34. CI green ✅ (smoke-and-tests only — no landing page CI). 12 files, +501/-0.
The landing page looks great — clean design, accurate project description, good accessibility (reduced-motion media query). But there are some structural concerns before this is ready to merge.
🔴 Blockers
1. Scope contamination: vscode-extension/openclaude-vscode/package-lock.json added
This PR adds a package-lock.json for the VS Code extension, which is completely unrelated to the landing page. This should be a separate PR. Including it here makes the diff noisy and ties an unrelated change to the landing page review.
2. No CI for the landing/ directory
The repo's CI (pr-checks.yml) runs bun install and bun test at the root level. The landing/ directory has its own package.json with react, vite, tailwindcss, etc. — but no CI workflow validates that npm run build succeeds, linting passes, or the page renders. This means landing page breakages won't be caught by CI.
Add a CI step (even a simple cd landing && npm install && npm run build) to pr-checks.yml, or create a separate workflow for the landing directory.
3. No deploy pipeline
There's no GitHub Actions workflow to deploy the landing page (GitHub Pages, Vercel, Cloudflare Pages, etc.). Without deployment, this is just static code sitting in the repo. How will this be published?
4. landing/package-lock.json is gitignored
The root .gitignore adds landing/package-lock.json, which means no lockfile will be committed. For reproducible builds, the lockfile should be committed (this is standard practice for npm projects — package-lock.json belongs in version control). Remove the gitignore entry and commit the lockfile instead.
🟡 Non-blocking
5. Missing files for production deployment
No favicon.ico, robots.txt, sitemap.xml, or meta tags for SEO/social sharing (Open Graph, Twitter cards). Fine for a first iteration, but needed before real deployment.
6. External Google Fonts dependency
@import url("https://fonts.googleapis.com/css2?family=...") creates a runtime dependency on Google Fonts. Consider self-hosting the fonts for privacy and reliability in production.
7. Missing trailing newlines in all new files
index.html, package.json, postcss.config.cjs, App.tsx, index.css, main.tsx, tailwind.config.ts, tsconfig.json, vite.config.ts all lack trailing newlines. Minor but noisy for future diffs.
Verdict: Needs changes 🔧
The landing page itself is well-done, but the structural issues need addressing before merge: remove the unrelated VS Code extension change, add CI for the landing directory, establish a deploy pipeline, and commit the lockfile for reproducible builds.
This pull request adds a new landing page for the OpenClaude project using a modern React + Vite + Tailwind CSS stack. It introduces all the necessary configuration, assets, and initial UI for the landing site, including a responsive, styled homepage that explains the project's features and setup instructions.
The most important changes are:
Landing Page UI and Content:
index.htmland a React-basedAppcomponent (src/App.tsx) that implements the main landing page UI, including feature highlights, a control center demo, and getting started instructions. The design uses custom styles and Tailwind CSS for a modern, developer-focused look. [1] [2]src/index.css) with theme variables, layout, and component styles to match the OpenClaude branding and enhance the user interface.Project Configuration and Tooling:
package.jsonwith dependencies for React, Tailwind CSS, Vite, and related tooling, and scripts for development, build, and preview.tsconfig.json), Tailwind CSS (tailwind.config.ts), PostCSS (postcss.config.cjs), and Vite (vite.config.ts) to enable a modern frontend development workflow. [1] [2] [3] [4].gitignoreto excludenode_modulesand build output.Entry Point and Bootstrapping:
src/main.tsx) to bootstrap the React application and mount it to the DOM.Miscellaneous:
package-lock.jsonfor the VSCode extension, likely to keep dependencies in sync (not directly related to the landing page, but included in this PR).