Skip to content

fix(revert): ensure the call is joined before notifying readiness #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverlaz merged 1 commit into from
Apr 9, 2026
+2 −6
Merged

fix(revert): ensure the call is joined before notifying readiness #2194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sample-apps/react/egress-composite/src/hooks/useNotifyEgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
useEffect,
useState,
} from 'react';
import { CallingState, useCallStateHooks } from '@stream-io/video-react-sdk';

const EgressReadyNotificationContext = createContext((isReady: boolean) => {
// no-op
Expand All @@ -15,13 +14,10 @@ const EgressReadyNotificationContext = createContext((isReady: boolean) => {

export const EgressReadyNotificationProvider = (props: PropsWithChildren) => {
const [isReady, setIsReady] = useState(false);
const { useCallCallingState } = useCallStateHooks();
const callingState = useCallCallingState();
useEffect(() => {
if (isReady || callingState !== CallingState.JOINED) return;
if (isReady) return;
// it could happen that components won't notify us that they are ready
// in that case, we start recording anyway after 4 seconds.
console.log('Egress: Started waiting for components to notify readiness');
const timeout = setTimeout(() => {
if (!isReady) {
console.log('Timeout: Egress is ready');
Expand All @@ -32,7 +28,7 @@ export const EgressReadyNotificationProvider = (props: PropsWithChildren) => {
return () => {
clearTimeout(timeout);
};
}, [callingState, isReady]);
}, [isReady]);

const spyIsReady = useCallback((value: boolean) => {
setIsReady((current) => {
Expand Down
Loading