Conversation
|
@Brazol , do you think we should also add the coordinator client too in this list? |
| # Skip generated files from showing up in diffs. | ||
| **/*.g.dart linguist-generated=true | ||
| **/*.freezed.dart linguist-generated=true | ||
| **/*.pb.dart linguist-generated=true |
There was a problem hiding this comment.
I'm not sure about pb files. They don't change often - only when regenerated and then we do want to see them in diff.
There was a problem hiding this comment.
I mean we can't really identify any issues in a generated code, unless we run it locally. It's also skipped from analyzer.
https://github.com/GetStream/stream-video-flutter/blob/main/analysis_options.yaml#L15
There was a problem hiding this comment.
True, and the analyzer makes sense. The thing is that we have some manual changes there that should be reapplied after regeneration. So it's good to have it in diff so that another pair of eyes can check if. by accident, some manual change wasn't removed.
2 participants
This pull request includes a change to the
.gitattributesfile to improve the handling of generated files in diffs. The most important change is the addition of rules to skip generated files from showing up in diffs.Changes to
.gitattributes:.g.dart,.freezed.dart,.pb.dart,.pbenum.dart,.pbjson.dart,.pbserver.dart,.pbtwirp.dart) as linguist-generated, so they are excluded from diffs.