Skip to content

[VID-579] Introduce unified_session_id and extend performance stats with target bitrate #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesyncim merged 1 commit into from
May 1, 2025
Merged

[VID-579] Introduce unified_session_id and extend performance stats with target bitrate #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
362 changes: 187 additions & 175 deletions protobuf/video/sfu/models/models.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions protobuf/video/sfu/models/models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,4 +413,6 @@ message PerformanceStats {
float avg_fps = 4;
// the track dimensions
VideoDimension video_dimension = 5;
// the target bitrate for the track, only for published tracks
int32 target_bitrate = 6;
}
27 changes: 27 additions & 0 deletions protobuf/video/sfu/models/models_vtproto.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

344 changes: 179 additions & 165 deletions protobuf/video/sfu/signal_rpc/signal.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions protobuf/video/sfu/signal_rpc/signal.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ message SendStatsRequest {
repeated models.PerformanceStats encode_stats = 16;
// Decode stats for the subscriber
repeated models.PerformanceStats decode_stats = 17;
// user_session id can change during reconnects, this helps us to
// identify the user across reconnects and should remain consistent until the user explicitly
// disconnects, is kicked or the call is ended.
string unified_session_id = 18;
}

message SendStatsResponse {
Expand Down
163 changes: 82 additions & 81 deletions protobuf/video/sfu/signal_rpc/signal.twirp.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 45 additions & 0 deletions protobuf/video/sfu/signal_rpc/signal_vtproto.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.