Skip to content

Conversation

@bookshiyi
Copy link

fixed issue: #655

@bookshiyi bookshiyi requested a review from tshedor as a code owner November 4, 2025 09:03
@bookshiyi bookshiyi changed the title Add Compare.inIterable to switch of compareSign() fix(sqlite): Add Compare.inIterable to switch of compareSign() Nov 9, 2025
@tshedor
Copy link
Collaborator

tshedor commented Nov 11, 2025

@bookshiyi is this purely a syntax update? This should not change any behavior, correct?

@casklord
Copy link

@tshedor

It does make a difference because before this fix I'm getting this error.

Try adding a default case or cases that match 'Compare.inIterable'.

I don't know why this fixed it though

@tshedor
Copy link
Collaborator

tshedor commented Nov 12, 2025

@casklord ah, the fix went out a few hours ago in 4.1.0+1. I hadn't published brick_sqlite with the existing code on main

@bookshiyi
Copy link
Author

@bookshiyi is this purely a syntax update? This should not change any behavior, correct?

@tshedor sorry, I ignored the problem of pub and github code out of sync, I thought I had fixed the problem of switch.

So far, you are right, this pr just used the syntax sugar of dart to optimize the code format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants