fix: Use /a/ prefix for authenticated REST API endpoints#1
Open
jychoe013 wants to merge 1 commit intoGerritCodeReview:masterfrom
Open
fix: Use /a/ prefix for authenticated REST API endpoints#1jychoe013 wants to merge 1 commit intoGerritCodeReview:masterfrom
jychoe013 wants to merge 1 commit intoGerritCodeReview:masterfrom
Conversation
When using http_basic authentication with standard Gerrit instances, the REST API requires the /a/ prefix for authenticated access. Without this prefix: - /changes/ endpoint returns anonymous/public data only - Credentials sent via --user are silently ignored With this fix: - /a/changes/ endpoint properly authenticates requests - All http_basic auth configurations now work correctly This issue was found when using the MCP server with a self-hosted Gerrit instance using http_basic authentication. Queries like "owner:self" failed with "Must be signed-in to use this operator" despite valid credentials being configured. Reference: https://gerrit-review.googlesource.com/Documentation/rest-api.html#authentication
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
+1 for this change, I also fail to get private repos with http basic auth. Please note: after checking out this PR - 6 tests are failing (might be related to gitcookie fix in master?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
http_basicauthentication with standard Gerrit instances, the REST API requires the/a/prefix for authenticated access.Problem:
/a/prefix, the/changes/endpoint returns anonymous/public data only--userare silently ignoredowner:selffail with "Must be signed-in to use this operator"Solution:
/changes/endpoints to/a/changes/http_basicauthentication works correctlyTesting
Tested against a self-hosted Gerrit instance (v3.x) using
http_basicauthentication:Reference