-
Notifications
You must be signed in to change notification settings - Fork 7
Fix Android 16 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rubo77
wants to merge
30
commits into
GermainZ:master
Choose a base branch
from
rubo77:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix Android 16 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework dependency
set Version to 1.4.1
- Add new unicornify style using unicornify.pictures avatar service with local caching (mentioned in GermainZ#26 ) - Update documentation with identicon styles information and links - Remove XposedBridge
- Implement VisiglyphsIdenticon.java with complete Java port of original PHP algorithm - Add 16 geometric patterns: mountains, triangles, diamonds, spikes, blocks, etc. - Create 3x3 grid layout with symmetric pattern arrangement and mirroring - Implement hash-based color extraction with contrast enhancement (fg colors masked with 239) - Generate all patterns locally without internet connectivity requirements Integration: - Add IDENTICON_STYLE_VISIGLYPHS constant and factory case to IdenticonFactory - Update arrays.xml with visiglyphs entries, values, and icon references - Add 'Visiglyphs' string resource to strings.xml - Create colorful vector drawable icon showing 3x3 grid pattern concept Documentation: - Add comprehensive visiglyphs attribution to NOTICE.md with original author credit - Update README.md feature list from six to seven identicon styles - Update changelog for version 1.5 with visiglyphs and offline improvements - Verify successful build and resolve compilation conflicts Technical: - Faithful port of original visiglyphs algorithm by Charles Darke - 16 distinct geometric patterns with rotation support (0-3 x 90°) - MD5 hash processing for pattern selection, rotation, and RGB color values - Efficient local generation using Android Canvas and Path drawing - Seamless integration with existing identicon infrastructure Based on: https://web.archive.org/web/20070929081457/http://digitalconsumption.com/files/pub-glyphs-beta.gz Original by: Charles Darke @ digitalconsumption.com (BSD-like license)
Multiple Style Selection: Users can now select multiple identicon styles simultaneously using checkboxes Random Selection: When generating contact images, the app randomly selects one style from the chosen set docs: add detailed explanation of identicon storage and sharing functionality
…ence implementation
… for style selection
…using foreground colors
|
and there is an even newer version here: https://github.com/rubo77/Identiconizer/releases/tag/1.5 i downloaded it and it is totally broken. i added four issues and went back to your version which works fine on my Graphene OS (Android 16). |
Author
|
thx for the reports, i commented on your issues and will look into it when i have some free time again ;) |
Co-authored-by: rubo77 <1591563+rubo77@users.noreply.github.com>
…ents Co-authored-by: rubo77 <1591563+rubo77@users.noreply.github.com>
…et.RecyclerView ... /> as required for AndroidX projects fixes #3
…iles and improve README for better discoverability Merge remote-tracking branch 'rubo77/copilot/fix-5'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33
Download the Version 1.4.1 which works on Android 16 here:
https://github.com/rubo77/Identiconizer/releases/tag/1.4.1