Skip to content

Pyshp 3.0.0 alpha pylint #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesParrott merged 17 commits into from
Jul 25, 2025
Merged

Pyshp 3.0.0 alpha pylint #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8f01e97
Update .gitignore
JamesParrott Jul 25, 2025
e2fb8c8
Update changelog.txt
JamesParrott Jul 25, 2025
e779501
Update run_checks_build_and_test.yml
JamesParrott Jul 25, 2025
d782371
Delete unreachable else clause
JamesParrott Jul 25, 2025
78684e9
Add (and use) specific GeoJSON Exception
JamesParrott Jul 25, 2025
b98a82a
Reformat
JamesParrott Jul 25, 2025
4f1a850
Restore code in else clause in Shape.__ geo_interface__
JamesParrott Jul 25, 2025
e365093
Suppress Pylint undefined loop variable and consider raise from warnings
JamesParrott Jul 25, 2025
90c31c0
Make some exceptions more specific, and unpack unassigned list compre…
JamesParrott Jul 25, 2025
f791dae
Update changelog.txt
JamesParrott Jul 25, 2025
3c58ae9
Make except only catch specific exceptions
JamesParrott Jul 25, 2025
88ebe03
Replace dbf Exception with ShapefileException
JamesParrott Jul 25, 2025
be1f5d2
Suppress KeyErrors from opening Zip archives
JamesParrott Jul 25, 2025
edbd735
Delete Py23DocChecker
JamesParrott Jul 25, 2025
87d97eb
Rename unpack helper
JamesParrott Jul 25, 2025
f8abdf2
Catch Type and ValueErrors only when forming date
JamesParrott Jul 25, 2025
98077e5
Prefix names of unused variables with __
JamesParrott Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/run_checks_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ jobs:
pip install pytest pylint pylint-per-file-ignores
pip install -e .
- name: run Pylint for errors and warnings only, on test_shapefile.py
continue-on-error: true
run: |
pylint --disable=R,C test_shapefile.py
pylint --disable=R,C test_shapefile.py src/shapefile.py

build_wheel_and_sdist:
runs-on: ubuntu-latest
Expand Down
7 changes: 5 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,8 @@ dist/
.vscode
.dmypy.json
.python-version
.venv
venv
.venv/
venv/
.mypy_cache/
.pytest_cache/
.ruff_cache/
15 changes: 15 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
VERSION 3.0.0-alpha

Python 2 and Python 3.8 support dropped

2025-07-22
Code quality
* Type hints
* f-strings
* Remove Python 2 specific functions.
* Run doctests against wheels.
* Testing of wheels before publishing them
* pyproject.toml src layout
* Slow test marked.


VERSION 2.4.0

2025-07-21
Expand Down
Loading
Loading