Skip to content

Fix Docker and black CI builds#366

Draft
jeremyh wants to merge 9 commits intodevelopfrom
jez/pre-commit-clean
Draft

Fix Docker and black CI builds#366
jeremyh wants to merge 9 commits intodevelopfrom
jez/pre-commit-clean

Conversation

@jeremyh
Copy link
Member

@jeremyh jeremyh commented Jul 12, 2023

The docker build is failing, as well as black (due to being unversioned -- so new releases broke it

  • Install scipy via conda, to fix docker build. The newer scipy requires Python 3.9+. Conda will already match versions correctly.
  • Use pre-commit black config, to avoid config duplication.
  • Update pre-commit to match other repos (eugl, wagl)

I've disabled some of the whitespace (end-of-file) normalising checks in pre-commit as it looks like they were never run across the whole repository previously.

jeremyh added 4 commits July 12, 2023 20:31
The unversioned black build is failing.

black is already specified (and frozen) in
pre-commit, so we should re-use that.

I've also updated the pre-commit config to
modernise and match our other repos.
Scipy 1.11 now requires Py3.9+
It will be built to match Python/etc versions.
@jeremyh jeremyh changed the title Fix/Stabilise black CI build Fix Docker and black CI builds Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant