fix: stabilize spearman distance correlation sampling#7
Draft
GeorgePearse wants to merge 1 commit intomainfrom
Draft
fix: stabilize spearman distance correlation sampling#7GeorgePearse wants to merge 1 commit intomainfrom
GeorgePearse wants to merge 1 commit intomainfrom
Conversation
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
sample_sizesubsample points (rows) before computing Spearman correlation over pairwise distances.Why
Sampling arbitrary pairs can be noisy and can over/under-emphasize regions depending on the distribution of pairs; subsampling points tends to give a more stable estimate for large datasets.
Testing