feat: integrate ty type checker and replace pre-commit with prek#25
Open
GeorgePearse wants to merge 1 commit intomainfrom
Open
feat: integrate ty type checker and replace pre-commit with prek#25GeorgePearse wants to merge 1 commit intomainfrom
GeorgePearse wants to merge 1 commit intomainfrom
Conversation
- Replace pre-commit with prek (Rust-based drop-in replacement) in dev deps - Add ty (Astral's fast Python type checker) as a local pre-commit hook - Configure ty in pyproject.toml: target genesis/ package, Python 3.12 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
pre-commitwithprekand integratety(Astral's Python type checker) into the monorepo.Changes
pre-commit==4.0.1forprek==0.3.3in dev dependencies. prek is a Rust-based drop-in replacement that reads the same.pre-commit-config.yamland runs significantly faster.ty checkhook in.pre-commit-config.yamlthat runs on all Python file changes.[tool.ty.src]and[tool.ty.environment]sections inpyproject.toml, targeting thegenesis/package with Python 3.12, excludingtests/,results/, andexamples/.Testing
prek installsucceeds and hooks are registeredty checkandprek run ty --all-filesboth execute correctly