Fix #200: Exclude shared edges between coplanar triangles from outlines#246
Merged
bertt merged 5 commits intofix/issue-200-improve-outlinesfrom Feb 2, 2026
Merged
Fix #200: Exclude shared edges between coplanar triangles from outlines#246bertt merged 5 commits intofix/issue-200-improve-outlinesfrom
bertt merged 5 commits intofix/issue-200-improve-outlinesfrom
Conversation
… changes Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix outlines for coplanar polygons to prevent diagonal lines
Fix #200: Exclude shared edges between coplanar triangles from outlines
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outline detection algorithm was drawing unwanted lines between coplanar triangles that don't appear sequentially in the geometry, creating diagonal artifacts on flat surfaces.
Changes
Coplanarity Detection
Triangle.AreCoplanar()to detect coplanar triangles via normal comparisonAdjacency Calculation
Adjacency.GetAdjacencyList()to include only shared edges between coplanar trianglesCross-Partition Handling
OutlineDetection.GetOutlines2()to compute global adjacency before partitioningPart.GetOutlines()to accept pre-calculated adjacency and handle single-triangle partsExample
Given this geometry where triangles 1 and 3 are coplanar (z=5) but triangle 2 is angled:
The shared edge between t0 and t2 is now correctly excluded from the outline, while the shared edge between t0 and t1 is included.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.