Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if the code is still maintained but here are several small fixes I introduced to try and run it without CGAL bindings. Putting them here if it can help.
As the libraries versions are not fixed, I stumbled upon compatibilities issues with newer versions of them.
np.boolsince1.24.0. I replaced it withboolas it seemsnp.boolwas only an alias on Pythonbooltype.geomsto iterate over themcascaded_unionis deprecated and will soon be replaced byunary_unionI also added two checks to prevent what seem to me as unnecessary breaking exceptions:
compute_shape()infit.pyI noticed that when @Geodan/concave-hull returns an invalid polygon (it does happen from time to time) the union will break. Added a check to prevent merging alpha shape geometry with invalid concave-hull geometrytriangle_geometry()inalpha_shape.pyI encountered some cases wheresqrt()had to deal with a very small negative number. I added atry: ... except ValueError: ...around it and initialized the area value to0