Merged
Conversation
GeniJaho
force-pushed
the
feature/photo-share
branch
from
e8c786a to
729a21e
Compare
- Move share token generation logic into GenerateShareTokenAction - Extract share endpoint to invokable SharePhotoController - Remove global $appends on Photo model, append full_path only where needed - Remove user data from shared photo page (privacy) - Fix isShareable() redundant instanceof check, remove stale phpstan baseline entries - Fix ShareIcon double-wrapping and console.log → console.error - Add 10 feature tests covering share link generation, access control, and expiry
- Show user profile photo (with initials fallback) on shared photo page - Load only user name and profile_photo_path for privacy - Translate all Dutch text to English (share page, modal, badges) - Move share button from photo overlay to between Previous/Next buttons - Delete ShareIcon component, use inline icon instead - Fix clipboard copy using execCommand fallback for non-HTTPS contexts
Build explicit data array in ShareController instead of serializing the full Photo model. Only exposes the fields the share page needs: image path, file name, date, view count, user name/photo, and item details with tags.
Users can choose Never, 7, 30, or 90 days expiry when sharing a photo. The modal shows expiry options first, then the generated link with expiry date. Each share generation creates a fresh token with the chosen expiry. The shared photo page displays the expiry date.
- Only generate a new token if one doesn't exist, otherwise just update the expiry date - Extract validation to SharePhotoRequest - Add test for updating expiry on existing token
- Introduced `RevokeSharePhotoController` with new route to revoke share links. - Updated `Show.vue` to include a "Delete link" button in the share modal. - Added feature tests for share link revocation, access control, and guest restrictions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functionality:
If you are on a photo that is interesting, you can click the 'share' button,
It will create a new link that you can share with somebody,
The other person can open the link and without logging in, it will see the photo and most of the meta-data