feat: pr template #55
Open
+100
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dao-Ho
reviewed
Jan 15, 2026
Contributor
Dao-Ho
left a comment
Dao-Ho
left a comment
There was a problem hiding this comment.
Just smol cmts but I feel like this template is very long & verbose imo. I'm down to do it but idk if it's worth forcing engs to fill out all of this every time they open a pr
.github/pull_request_template.md
Outdated
| - [ ] No sensitive data (passwords, tokens, API keys, PII, etc.) committed | ||
| - [ ] Security implications considered and addressed | ||
| - [ ] Performance impact evaluated (no obvious performance regressions) | ||
|
|
Contributor
There was a problem hiding this comment.
I feel like this checklist will be glossed over so easily tbh 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created pr template