Support nullable download timeout option #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed DownloadTimeOut option type to nullable int and updated usage to handle null values, allowing more flexible configuration of download timeout settings.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the DownloadTimeOut option type from int to int? (nullable int) to allow more flexible configuration. When no value is provided, the code defaults to 60 seconds using the null-coalescing operator.
Key changes:
- Changed
UpdateOption.DownloadTimeOutfromUpdateOption<int>toUpdateOption<int?>to support nullable values - Simplified the null-coalescing assignment in
GeneralUpdateBootstrap.csby removing an unnecessary intermediate variable GeneralClientBootstrap.cswas modified but appears to have a critical file encoding issue
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/c#/GeneralUpdate.Common/Internal/Bootstrap/UpdateOption.cs | Changed DownloadTimeOut option type from int to int? to support nullable configuration values |
| src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs | Simplified assignment by removing intermediate variable and directly using null-coalescing operator with 60-second default |
| src/c#/GeneralUpdate.ClientCore/GeneralClientBootstrap.cs | File has a critical encoding corruption issue with spaces inserted between all characters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static readonly UpdateOption<Encoding> Encoding = ValueOf<Encoding>("COMPRESSENCODING"); | ||
|
|
||
| /// <summary> | ||
| /// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 30 seconds. |
There was a problem hiding this comment.
The comment states the default timeout period is 30 seconds, but the actual default value used throughout the codebase is 60 seconds. The comment should be updated to match the implementation.
Suggested change
| /// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 30 seconds. | |
| /// Timeout period (unit: second). If this parameter is not specified, the default timeout period is 60 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed DownloadTimeOut option type to nullable int and updated usage to handle null values, allowing more flexible configuration of download timeout settings.