Skip to content

Conversation

@audreyyeoCH
Copy link
Collaborator

closes #146

referring to the above issue from @yannick

FALSE -> TRUE here

audreyyeoCH and others added 15 commits October 10, 2025 09:14
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
@danielinteractive
Copy link
Collaborator

Thanks @audreyyeoCH , can you please make a new branch for this small fix? Otherwise there are many other changes here in this PR. Thanks!

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              99       3  96.97%   32, 62, 154
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              83      83  0.00%    42-130
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   113
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                36       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2477     433  82.52%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6a8d1c7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPredprob 💚 $210.46$ $-1.85$ $0$ $0$ $0$ $0$
plotOc 💚 $214.92$ $-5.12$ $0$ $0$ $0$ $0$
predprobDist 💔 $26.26$ $+9.28$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprob 💚 $207.62$ $-1.85$ ocPredprob_correctly_shows_maximum_sample_size_when_no_decision_reached
plotOc 💚 $57.16$ $-1.18$ h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc 💚 $105.52$ $-2.89$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status
predprobDist 💔 $2.29$ $+1.81$ h_predprobdist_gives_correct_list
predprobDist 💔 $6.59$ $+3.42$ h_predprobdist_gives_higher_predictive_probability_when_thetaT_is_lower
predprobDist 💔 $11.91$ $+2.38$ predprobDist_gives_higher_predictive_probability_when_thetaT_is_lower_in_a_single_arm_trial
predprobDist 💔 $4.63$ $+1.61$ predprobDist_gives_the_correct_results_in_a_two_arm_study

Results for commit 94f096b

♻️ This comment has been updated with latest results.

@yannick
Copy link

yannick commented Dec 10, 2025

when False becomes True it is time for me to shine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in ocPredprob - h_get_decision_one_predprob

4 participants