Skip to content

Conversation

@audreyyeoCH
Copy link
Collaborator

@audreyyeoCH audreyyeoCH commented Oct 11, 2025

new pr to continue from #143 , sorry about that

@audreyyeoCH audreyyeoCH self-assigned this Oct 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              99       3  96.97%   32, 62, 154
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              83      83  0.00%    42-130
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   113
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                36       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2477     433  82.52%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  --------
R/plotBounds.R      +31     +31  +100.00%
TOTAL               +31     +31  -1.05%

Results for commit: 155d3ef

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

Unit Tests Summary

    1 files     20 suites   9m 58s ⏱️
  140 tests   140 ✅ 0 💤 0 ❌
3 764 runs  3 764 ✅ 0 💤 0 ❌

Results for commit 155d3ef.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPredprob 💔 $200.49$ $+2.99$ $0$ $0$ $0$ $0$
plotOc 💔 $208.48$ $+3.94$ $0$ $0$ $0$ $0$
predprobDist 💔 $22.07$ $+2.43$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprob 💔 $197.76$ $+2.84$ ocPredprob_correctly_shows_maximum_sample_size_when_no_decision_reached
plotOc 💔 $102.32$ $+2.16$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status
predprobDist 💔 $9.67$ $+1.25$ predprobDist_gives_higher_predictive_probability_when_thetaT_is_lower_in_a_single_arm_trial

Results for commit 7cf6025

♻️ This comment has been updated with latest results.

audreyyeoCH and others added 5 commits October 12, 2025 16:13
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Audrey!

@audreyyeoCH audreyyeoCH reopened this Oct 15, 2025
@audreyyeoCH audreyyeoCH merged commit 1306d70 into main Oct 15, 2025
26 checks passed
@audreyyeoCH audreyyeoCH deleted the 98_Design_doc_plotBounds branch October 15, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants