Skip to content

Conversation

@ninarobbins
Copy link
Collaborator

Quicklook script and draft of functions.


# Select subset of satellite domain
img = pr.Image(m)
subset = img.subset_region_from_latlon_extents(extent, unit="degree")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to how we get mean launch time from the dropsondes, I think the default extents should also be dependent on the actual launch locations, rather than a fixed bounding box.



# Access satellite data
satellite_image = ql.get_satellite_data(**kwargs)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The **kwargs are not defined in the file. Also, they are not needed as their aim is to pass on the non-default arg values, which we will have the main function do. So, for this function call and all others in this script, it should work to simply have empty parentheses.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also should solve the CI failing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments! I put it there as a place holder but realize how it would cause an error... I fixed this and also adjusted the default extents.

@ninarobbins ninarobbins self-assigned this Jul 11, 2023
@ninarobbins ninarobbins marked this pull request as ready for review May 23, 2024 13:22
@ninarobbins ninarobbins marked this pull request as draft May 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants