Made Hamburger a controlled component #5
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to animation only if a certain condition is met, like only when navigating to a certain page. Also fixed an issue where this.props.active was being used instead of nextProps.active
Author
|
@sankhadeeproy007 Could you take a look at this? |
Author
|
@himanshu-satija @Nyl000 If either of you have write access to this repo, could you take a look at this PR? |
|
I'd love to see this merged! |
|
Still really looking forward to this! It's a great repo. Please let the community know if you need help maintaining. |
Added typescript types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to animate only if a certain condition is met, like only when navigating to a certain page. Also fixed an issue where
this.props.activewas being used instead ofnextProps.active