Replace console logger by ILogger when a background service had a critical error and is shutting down the application.#23
Replace console logger by ILogger when a background service had a critical error and is shutting down the application.#23kevgeni wants to merge 4 commits intoGeeWee:mainfrom
Conversation
…tical error and is shutting down the application.
|
After having time to look at the PR - the actual changes you're making does break some stuff regarding the I don't seem to have edit access to the PR, but I've made some changes and here's two git patch files you can apply to your PR that should get it into a working state. Let me know if you have any questions! |
|
Hello there I've added you to my git repo (not sure if I did right, github is not my preferred platform) in case you need to do other modifications like this before merging. If we could have cleared the confusion about why there was some coding errors, I would have probably also fixed it. Hope you like it. |
There was a log of coding style errors in the repo and it would not build. My modification was pretty small so I did not modify those. I suppose there is a refactoring in progress in a different branch.