This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Potential fixes for off-by-one errors#7
Open
jaeaster wants to merge 1 commit intoGearbox-protocol:lagrange-distributorfrom
Open
Potential fixes for off-by-one errors#7jaeaster wants to merge 1 commit intoGearbox-protocol:lagrange-distributorfrom
jaeaster wants to merge 1 commit intoGearbox-protocol:lagrange-distributorfrom
Conversation
jaeaster
commented
Aug 7, 2024
| _campaigns[campaignId].rewards.push(rewards[i]); | ||
| IERC20(rewards[i].rewardToken).safeTransferFrom( | ||
| msg.sender, address(this), rewards[i].rewardRate * (endBlock - startBlock) | ||
| msg.sender, address(this), rewards[i].rewardRate * (endBlock - startBlock + 1) |
Author
There was a problem hiding this comment.
Lagrange queries are inclusive of the range; do you want the campaign to work in the same way? e.g.
startBlock = 1
endBlock = 2
=> 2 blocks of rewards in the campaign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.