This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Merged
Conversation
lekhovitsky
force-pushed
the
next
branch
2 times, most recently
from
c0038fc to
6c1b6ac
Compare
Write tests, kids, even when in hurry
lekhovitsky
force-pushed
the
getter-updates
branch
from
f7ea7db to
86842f3
Compare
--------- Co-authored-by: Mikael <26343374+0xmikko@users.noreply.github.com>
In this commit: - upgrade deps - CF and CC no longer expect ACL as constructor argument - credit factory reads WETH from AP in runtime and not in constructor - aliased loss policy conforms to default constructor signature - add missing serialization - revert on non-v3 minor version - `getLatestMinorVersion` and `getLatestPatchVersion` accept non-exact versions
feat: add `DefaultDegenNFT`, fix some bugs and add configuration tests
feat: ccg proposal naming change + recovery mode
In this PR: - updatable price feeds now live in `PriceFeedStore` instead of `PriceOracleV3` - `PriceFeedStore` allows to configure price feeds it owns (think `setLimiter` in LP price feeds) - some fixes and improvements in `PriceOracleFactory` - allow reserve price feed to be `ZeroPriceFeed` even if it's not added to allowed price feeds for a token - fix migration from legacy price oracle - gas-optimize migration of price feeds - minor fixes in `NestedPriceFeeds` library - general refactoring of `PriceFeedStore` (better execution flow, NatSpec, etc.) - minor changes related to `ILossPolicy` interface upgrade
lekhovitsky
force-pushed
the
getter-updates
branch
from
98ea22a to
5447bb5
Compare
* feat: add `removePriceFeed` to the store Additionally, removes the obsolete `author` field from the `PriceFeedInfo` struct. * fix: cleanup `MarketConfiguratorFactory` + unit tests * feat: cleanup `InstanceManager` + unit tests * fix: generalized legacy periphery contracts migration * feat: cleanup `AddressProvider` + unit tests * chore: update bindings
- `MarketConfigurator`'s `authorizeFactory` and `unauthorizeFactory` no longer revert on no-ops - `CreditFactory`'s `upgradeCreditConfigurator` quotes all tokens in legacy credit managers - `CreditFactory`'s `allowAdapter` now automatically unauthorizes previous adapter for the target contract if it was set - `MarketConfiguratorLegacy` no longer authorizes factories for contracts that are not used after the migration - `LegacyParams` now includes `priceOracle` since we've moved away from the idea of deploying a price oracle for each pool before migration
Also remove it in contracts where it wasn't that needed
- make system more robust against instance operator strategically placing `uploadBytecode` and `submitAuditReport` within governance transactions - cleaner separation between system and public domains (they are either system or public and it's one-way now, only public contracts have owner) - more comprehensible protection against domain squatting by compromised auditor - better contract type and version validation and control
- Recovery mode message is now chain-specific - In recovery mode, self-calls are not skipped - `disableRecoveryMode` must be the only call in the batch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.