Gdm/add a script to run first configuration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ script/detect_os_and_package_manager.sh: add script to detect operating system and package manager ✨ script/install_zsh_and_oh_my_zsh.sh: add script to install zsh and oh-my-zsh based on detected os and package manager
🗑️ package.json: delete unused package manager configuration
✨ script/oh_my_zsh_plugins_installation.sh: create a new script to install essential oh-my-zsh plugins based on the detected operating system and package manager
🔧 install_zsh_and_oh_my_zsh.sh: remove unsupported package managers from installation logic 🔧 oh_my_zsh_plugins_installation.sh: improve plugin installation feedback and add checks for existing plugins 🗑️ settings.json: delete obsolete settings file
✨ script/install_p10k_theme_for_omz.sh: create script to install MesloLGS NF font for Powerlevel10k theme ✨ script/install_zsh_and_oh_my_zsh.sh: enhance Zsh installation with OS detection and Homebrew checks ✨ script/oh_my_zsh_plugins_installation.sh: improve plugin installation logic for macOS and Linux 🔧 script/detect_os_and_package_manager.sh: update OS and package manager detection with user-friendly messages 🔧 script/main.sh: add TODOs for script execution order and permissions
There was a problem hiding this comment.
Pull request overview
This PR introduces a set of shell scripts to automate the first-time configuration of a development environment, specifically for installing Zsh, Oh My Zsh, PowerLevel10k theme, and related plugins. The PR also removes VS Code settings and package manager configuration files from version control.
Key changes include:
- Creation of modular shell scripts for automated environment setup
- Removal of personal VS Code settings and Yarn package manager configuration
- Implementation of cross-platform support (macOS and Linux) for development tools installation
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.json | Removed personal VS Code configuration file from repository |
| package.json | Removed Yarn package manager configuration |
| script/detect_os_and_package_manager.sh | Added OS and package manager detection utility (sourced by other scripts) |
| script/install_zsh_and_oh_my_zsh.sh | Added automated Zsh and Oh My Zsh installation script |
| script/install_p10k_theme_for_omz.sh | Added PowerLevel10k theme font installation script |
| script/oh_my_zsh_plugins_installation.sh | Added Oh My Zsh plugins installation automation |
| script/main.sh | Added placeholder main script with TODO comments |
Comments suppressed due to low confidence (1)
settings.json:1
- The
install.shscript (lines 60-64) attempts to symlinksettings.json, but this file has been deleted in this PR. This will cause the symlink creation to fail. Either:
- Keep the
settings.jsonfile if it's needed - Remove the settings.json handling from the install.sh script
- Add conditional logic to handle the case where settings.json doesn't exist
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✨ script/common.sh: add functions to clone repositories, plugins, and themes 🔧 script/install_p10k_theme_for_omz.sh: integrate common functions for theme installation and update README links 🔧 script/install_zsh_and_oh_my_zsh.sh: enhance output messages for OS and package manager configuration 🔧 script/oh_my_zsh_plugins_installation.sh: utilize common functions for plugin installation and clean up code 🔧 script/detect_os_and_package_manager.sh: remove redundant output for OS and package manager summary 🔧 script/main.sh: change file mode to executable
🔧 script/install_zsh_and_oh_my_zsh.sh: update installation messages and logic for Homebrew and Zsh 🔧 script/oh_my_zsh_plugins_installation.sh: improve installation messages and logic for autojump and fzf 🔧 script/install_p10k_theme_for_omz.sh: refine installation messages and add guidance for next steps 🔧 script/detect_os_and_package_manager.sh: standardize output messages for OS and package manager detection 🔧 script/common.sh: update echo messages for consistency across scripts
✨ script/setup_ssh_keys.sh: create a new script for setting up SSH keys with user prompts and instructions 🔧 config: organize GitHub and GitLab configurations for SSH keys 🔧 aliases: remove unused speedtest and serve aliases, retain phpstorm alias 🔧 gitconfig: update user email and add git-lfs filter configurations 🔧 zshrc: enhance Oh My Zsh configuration with additional plugins and environment variables 🔧 .gitignore_global: add .so files to the global ignore list
🔧 setup_ssh_keys.sh: enhance ssh key setup process with os detection and keychain installation 🔧 detect_os_and_package_manager.sh: refactor os detection logic for better compatibility ✨ config_linux, config_macos: add ssh configuration templates for Linux and macOS
🔧 script/setup_ssh_keys.sh: refactor variable names for clarity and improve existing key check logic 🔧 script/install_zsh_and_oh_my_zsh.sh: remove unnecessary blank line 🔧 zshrc: remove obsolete ssh agent configuration
Owner
Author
|
Maybe VSCode est capable de stocker la clé SSH comme PHPStorm, et donc pas besoin d'un agent ? (est-ce que ça se limite à VSCode et son utilisation interne ou terminal aussi ok dans ce cas ?) |
📝 setup_ssh_keys.sh: update prompts for key identification and adjust SSH config path 🔧 config_linux: add IdentityFile directive for SSH key 🔧 config_macos: ensure IdentityFile directive is present for SSH key
🔧 script/setup_ssh_keys.sh: update key name validation and improve configuration output 🔧 ssh/config_linux, ssh/config_macos: generalize host configuration for all services
# script/main.sh: add a todo for enabling script execution from anywhere
🔧 script/main.sh: delete todo for global script execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.