Skip to content

hyperref package compatibility fix.#12

Closed
kgeorgiy wants to merge 1 commit intoGassaFM:masterfrom
kgeorgiy:master
Closed

hyperref package compatibility fix.#12
kgeorgiy wants to merge 1 commit intoGassaFM:masterfrom
kgeorgiy:master

Conversation

@kgeorgiy
Copy link

@kgeorgiy kgeorgiy commented Nov 6, 2021

The \lastpage@putlabel was replaced by conditional definition of \lastpage@putl@bel, as proposed by the section 3.13. Other packages manipulating \lastpage@putlabel of the lastpage package documentation.

The \lastpage@putlabel was replaced by conditional definition of \lastpage@putl@bel,
as proposed in section "3.13. Other packages manipulating \lastpage@putlabel"
of the lastpage package documentation
https://mirror.lyrahosting.com/CTAN/macros/latex/contrib/lastpage/lastpage.pdf
@GassaFM
Copy link
Owner

GassaFM commented Nov 6, 2021

Thank you for the pull request!

Unfortunately, this change results in "Page 1 of ??" locally for me, even with multiple (two by default) compilations, with warnings like

LaTeX Warning: Reference `LastPage' on page 1 undefined on input line 59.

The .aux file just does not contain the line

\newlabel{LastPage}{{}{5}}

So perhaps some more of a workaround is needed.

@kgeorgiy
Copy link
Author

kgeorgiy commented Dec 30, 2021

The proper fix will require way too much copy-and-paste from the lastpage package, so I've decided to fix lastpage package compatibility instead.

@kgeorgiy kgeorgiy closed this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants