Draft
Conversation
tenderlove
force-pushed
the
pure-ruby
branch
2 times, most recently
from
d463669 to
8883456
Compare
We should try using this for benchmarks
Nakilon
reviewed
Jan 9, 2023
| end | ||
|
|
||
| def set(y, x, z, val) | ||
| i = z + (x * @z) + (y * @z * @x) |
There was a problem hiding this comment.
Hi. I'm just randomly subscribed to this repo and was interested by seeing such pull request.
Just wanted to say that AFAIK this won't do any profit in Ruby, you better just have real 3d array. Not sure if there are benchmarks here but I bet on this.
Contributor
Author
There was a problem hiding this comment.
I don't really want to rewrite this to use a "real 3d array". You're welcome to do it and test the performance. My guess is that they'd be pretty much the same, or this version is faster. Why?
- A real 3d array will have many more objects, causing more time in GC
- A real 3d array will require more pointer chasing (we would have to dereference more objects)
In the presence of a JIT compiler, this version will no doubt be faster (math is much cheaper than reading memory). Again, you're welcome to test!
|
@Gargron Friendly ping 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I ported the C implementation to pure Ruby (the code is not pretty since it's pretty much a straight port from the C code). I don't know how fast this is compared to the C implementation. I did this because I think it would make a good JIT benchmark, especially since we can compare against the C implementation.
The commit doesn't replace the existing C implementation, it just adds an
encode_rbfunction. I don't expect this PR to be merged necessarily, I just wanted to send it and say "hey, there's a pure Ruby version if you want it! 😄"