Update Section 5 to include both product and merchant reviews#7
Open
alejandro-runner wants to merge 2 commits intoGammaMarkets:mainfrom
Open
Update Section 5 to include both product and merchant reviews#7alejandro-runner wants to merge 2 commits intoGammaMarkets:mainfrom
alejandro-runner wants to merge 2 commits intoGammaMarkets:mainfrom
Conversation
…d section and added second sample json for merchant review
|
i think the approach makes sense, keeping it in the same kind some things to consider for the devs here:
|
|
two concerns to address :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach uses the same kind for both product and merchant reviews allowing for the mandatory
dtag to point to either an addressable tag representing the product"a:30402:<merchant-pubkey>:<product-d-tag>"or a profile tag representing the merchant["p", "<merchant-pubkey>"].Having the same kind for both makes it easy for buyers to find relevant reviews.