Skip to content

Atomic for BsModule #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonesmz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Atomic for BsModule #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 39 additions & 11 deletions Source/Foundation/bsfUtility/Utility/BsModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ namespace bs
if (isStartedUp())
BS_EXCEPT(InternalErrorException, "Trying to start an already started module.");

_instance() = bs_new<T>(std::forward<Args>(args)...);
T * test = nullptr;
bool const success = _instance().compare_exchange_strong(test, bs_new<T>(std::forward<Args>(args)...));

if (!success)
BS_EXCEPT(InternalErrorException, "Race condition when starting module.");

isStartedUp() = true;

((Module*)_instance())->onStartUp();
Expand All @@ -86,7 +91,12 @@ namespace bs
if (isStartedUp())
BS_EXCEPT(InternalErrorException, "Trying to start an already started module.");

_instance() = bs_new<SubType>(std::forward<Args>(args)...);
T * test = nullptr;
bool const success = _instance().compare_exchange_strong(test, bs_new<SubType>(std::forward<Args>(args)...));

if (!success)
BS_EXCEPT(InternalErrorException, "Race condition when starting module.");

isStartedUp() = true;

((Module*)_instance())->onStartUp();
Expand All @@ -95,6 +105,18 @@ namespace bs
/** Shuts down this module and frees any resources it is using. */
static void shutDown()
{
struct ScopeGuard
{
ScopeGuard(Module* inst)
: m_inst(inst)
{ }
~ScopeGuard()
{
bs_delete(inst);
}
Module* m_inst;
};

if (isDestroyed())
{
BS_EXCEPT(InternalErrorException,
Expand All @@ -107,9 +129,15 @@ namespace bs
"Trying to shut down a module which was never started.");
}

((Module*)_instance())->onShutDown();
Module* const inst = _instance().exchange(nullptr);

if (nullptr == inst)
BS_EXCEPT(InternalErrorException, "Race condition when starting module.");

ScopeGuard guard(inst);

inst->onShutDown();

bs_delete(_instance());
isDestroyed() = true;
}

Expand All @@ -122,7 +150,7 @@ namespace bs
protected:
Module() = default;

virtual ~Module() = default;
~Module() = default;

/*
* The notion of copying or moving a singleton is rather nonsensical.
Expand All @@ -149,9 +177,9 @@ namespace bs
virtual void onShutDown() {}

/** Returns a singleton instance of this module. */
static T*& _instance()
static std::atomic<T*>& _instance()
{
static T* inst = nullptr;
static std::atomic<T*> inst{nullptr};
return inst;
}

Expand All @@ -160,16 +188,16 @@ namespace bs
*
* @note If module was never even started, this will return false.
*/
static bool& isDestroyed()
static std::atomic<bool>& isDestroyed()
{
static bool inst = false;
static std::atomic<bool> inst{false};
return inst;
}

/** Checks has the Module been started up. */
static bool& isStartedUp()
static std::atomic<bool>& isStartedUp()
{
static bool inst = false;
static std::atomic<bool> inst{false};
return inst;
}
};
Expand Down