Open
Conversation
Contributor
HalfdanBrage
left a comment
HalfdanBrage
left a comment
There was a problem hiding this comment.
Great work! However as you mentioned this does not fit the design of the player character. The player design is based on a state machine implementation, where all logic for the state is contained within a node. Come speak with me at a GDC meeting, and we can implement coyote time within the design of the player character together :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added coyote time functionality to the player controller script. I am not sure the way it is implmented fits the general design of the player controller, but it the did not seem to break any functionality. Tell me if it is not implemented correctly.