fix: remove lossy percentage conversion in DKG randomness config#44
Merged
Lchangliang merged 5 commits intoaptos-nodefrom Feb 9, 2026
Merged
fix: remove lossy percentage conversion in DKG randomness config#44Lchangliang merged 5 commits intoaptos-nodefrom
Lchangliang merged 5 commits intoaptos-nodefrom
Conversation
The convert_randomness_config_from_api function was converting FixedPoint64 threshold values through an integer percentage round-trip: FixedPoint64 → percentage (u64) → FixedPoint64 This caused precision loss (e.g., 2/3 = 0.6666... → 66% → 0.66), leading to different DKG rounding weights between transcript generation and epoch transition wconfig reconstruction (W=4 vs W=11), resulting in an index out-of-bounds crash in weighted_protocol.rs. Fix: directly construct ConfigV1/ConfigV2 with the original FixedPoint64 values, preserving full precision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.