Skip to content

Conversation

@nstarman
Copy link
Contributor

No description provided.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v1.10.x milestone Jan 31, 2026
Copilot AI review requested due to automatic review settings January 31, 2026 17:21
@github-actions github-actions bot added the 🐛 Fix a bug Fix a bug. label Jan 31, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the lt_p (less than primitive) and ne_p (not equal primitive) dispatch implementations by replacing incorrect function calls with the correct quaxed equivalents.

Changes:

  • Added import for quaxed.numpy as qnp
  • Replaced qlax.lt calls with qnp.less in all three lt_p dispatch functions
  • Replaced jnp.not_equal calls with qnp.not_equal in all three ne_p dispatch functions

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.65%. Comparing base (202067c) to head (c0ee49c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   96.75%   96.65%   -0.10%     
==========================================
  Files          55       44      -11     
  Lines        2313     2184     -129     
  Branches       86       80       -6     
==========================================
- Hits         2238     2111     -127     
+ Misses         56       55       -1     
+ Partials       19       18       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nstarman nstarman merged commit ecb91be into GalacticDynamics:main Jan 31, 2026
35 of 36 checks passed
@nstarman nstarman deleted the unxt/fix-lt-dispatch branch January 31, 2026 17:26
meeseeksmachine pushed a commit to meeseeksmachine/unxt that referenced this pull request Jan 31, 2026
nstarman added a commit that referenced this pull request Jan 31, 2026
Co-authored-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 Fix a bug Fix a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant