⬆️ dep-bump: unxt, coordinax #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request upgrades two key dependencies (unxt and coordinax) and adapts the codebase to accommodate API changes introduced in these new versions.
Changes:
- Bumped
unxtfrom 1.7.7 to 1.10.3 - Bumped
coordinaxfrom 0.23.1 to 0.23.2 - Adapted code to use updated public APIs instead of internal imports
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated dependency versions for coordinax (0.23.2), unxt (1.10.3), quaxed (0.10.4), and added new transitive dependency unxt-api (1.10.1) |
| pyproject.toml | Updated minimum version requirements for coordinax and unxt |
| src/galax/potential/_src/xfm/translate.py | Removed internal API import and updated type annotation to use public API |
| src/galax/potential/_src/params/core.py | Removed internal API import and updated type annotations in method signatures |
| src/galax/potential/_src/params/constant.py | Removed internal API import and updated type annotation |
| src/galax/potential/_src/params/base.py | Removed internal API import, updated type annotations, and converted __all__ to tuple |
| src/galax/dynamics/_src/parsetime.py | Removed internal API import, updated type annotation, and converted __all__ to tuple |
| src/galax/coordinates/_src/psps/core.py | Removed obsolete type: ignore comment from dispatch decorator |
| src/galax/coordinates/_src/pscs/base_single.py | Removed obsolete type: ignore comment from dispatch decorator |
| src/galax/coordinates/_src/pscs/base_composite.py | Removed obsolete type: ignore comment from dispatch decorator |
| src/galax/coordinates/_src/base.py | Updated wadler-lindig API call to use consolidated parameter syntax |
| src/galax/_interop/galax_interop_astropy/potential.py | Removed obsolete type: ignore comments from dispatch decorators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 95.86% 95.86% -0.01%
==========================================
Files 160 160
Lines 6050 6046 -4
==========================================
- Hits 5800 5796 -4
Misses 250 250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.