Skip to content

Conversation

@nstarman
Copy link
Contributor

@nstarman nstarman commented Jun 9, 2025

This PR changes from the verbose

class MethodFlag: ...

def relax_time_specific_method(): ...

@dispatch
def relaxation_time(type[MethodFlag], ...):
    return relax_time_specific_method()

to the simpler

class Method: ...
    def __call__(*args): ...


@dispatch
def relaxation_time(type[MethodFlag], ...):
    return Method(params)(*args)

What do you think?

@nstarman nstarman requested a review from adrn June 9, 2025 15:10
@nstarman nstarman changed the title ✨ feat(dynamics): class-baed relaxation time calculators ✨ feat(dynamics): class-based relaxation time calculators Jun 9, 2025
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@nstarman nstarman force-pushed the gd/cluster/refactor-relax-times branch from 313ba86 to 4a486b2 Compare June 9, 2025 16:47
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (9ff983d) to head (4a486b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   95.84%   95.85%   +0.01%     
==========================================
  Files         158      158              
  Lines        5963     5989      +26     
==========================================
+ Hits         5715     5741      +26     
  Misses        248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nstarman nstarman added this to the v0.1 milestone Jun 9, 2025
@nstarman nstarman marked this pull request as ready for review June 9, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant