Remove UserPlugs and CompoundDataPlugValueWidget #6743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is completely superceded by PlugCreationWidget.
LayoutPlugValueWidget and PlugCreationWidget provide everything we need.
Contributor
murraystevenson
left a comment
murraystevenson
left a comment
There was a problem hiding this comment.
Thanks John! One suggestion inline, but otherwise this looks good to merge.
| GafferUI.PlugWidget( self.getPlug()["type"] ) | ||
| GafferUI.PlugWidget( self.getPlug()["data"] ) | ||
| GafferUI.CompoundDataPlugValueWidget( self.getPlug()["parameters"] ) | ||
| GafferUI.PlugValueWidget.create( self.getPlug()["parameters"] ) |
Contributor
There was a problem hiding this comment.
Might be worth also registering the below to prevent ObjectPlugs from appearing in the menu?
"outputs.*.parameters" : {
"plugCreationWidget:excludedTypes" : "Gaffer.ObjectPlug",
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were made redundant by #6726, so it makes sense to remove them for Gaffer 1.7.