Skip to content

Conversation

@danieldresser-ie
Copy link
Contributor

Pretty straightforward, with just one weird floating point rounding thing, which has been documented and probably tested enough that there aren't any problems ( at least not with images smaller than 16 million pixels across ).

( Recreated with branch in the main repo, so the renderer tests run ).

Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! I suspect this has exposed a bug in our new display driver for XPU, since overscan isn't coming out right in XPU interactive renders (RIS top, XPU bottom) :

image

Would be good to get that sorted before merging (seems like it might be related to the crop window code you mentioned you'd been looking at anyway).

@danieldresser-ie
Copy link
Contributor Author

I've added an additional commit that overhauls the XPU display driver, addressing both your observation here and #6727.

I've tested it a fair bit interactively, and am pretty confident that it's working now, but I haven't yet added tests, and I also haven't yet addressed the non-XPU part of #6727 ( Not sure how important it is to deal correctly with changing the dataWindow interactively for non-XPU renders ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants